mukul1987 edited a comment on pull request #2520:
URL: https://github.com/apache/ozone/pull/2520#issuecomment-896408659


   Agree to comment from @adoroszlai 
   
       public static boolean validateChunkForOverwrite(File chunkFile,
         ChunkInfo info) {
   
       if (isOverWriteRequested(chunkFile, info)) {
         if (!isOverWritePermitted(info)) {
           LOG.warn("Duplicate write chunk request. Chunk overwrite " +
               "without explicit request. {}", info);
         }
         return true;
       }
       return false;
     }
   
   Apart from logging a warning can we also change it to a precondition to fail 
the write ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to