sadanand48 commented on pull request #2520:
URL: https://github.com/apache/ozone/pull/2520#issuecomment-897013106


   > Apart from logging a warning can we also change it to a precondition to 
fail the write ?
    
    In the current version of the patch , this check would happen only on 
enabling a config which I have disabled by default. If the config is turned on 
, the write would fail if  offset!=length and there are certain scenarios where 
this can cause an issue observed by unit tests. For example if a datanode 
receives a writechunk after a container dir is deleted, it would fail the 
writechunk without marking container unhealthy and the container would still be 
open (TestContainerStateMachine#testContainerStateMachineFailure) . Need to 
handle such cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to