sodonnel commented on PR #11884:
URL: https://github.com/apache/ozone/pull/11884#issuecomment-6955130813

   I think this updated version is simpler. A few minor things:
   
   1. We should update hte PR description with the benchmark results of this 
version of the code, as otherwise we can commit with incorrect benchmarks on 
the PR description.
   2. A cache limit of 64 seems quite small. Would 1024 make more sense? I 
guess there shouldn't be too many instances in practice, so perhaps 64 is fine. 
I am somewhat worried about clients passing a lot of variations of the string 
value filling up the string "fast path".
   
   I also left one comment inline.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to