chihsuan commented on code in PR #12101:
URL: https://github.com/apache/ozone/pull/12101#discussion_r4642926639


##########
dev-support/ci/populate-cache.sh:
##########
@@ -14,28 +14,23 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-#checks:basic
-
 set -u -o pipefail

Review Comment:
   Should we add `-e` here so that a failed `install` or `compile` doesn't save 
a partial cache?
   
   
   ```suggestion
   set -e -u -o pipefail
   ```



##########
pom.xml:
##########
@@ -3053,12 +3054,10 @@
     <profile>
       <id>go-offline</id>
       <properties>
-        <cyclonedx.skip>true</cyclonedx.skip>

Review Comment:
   This seems re-enables `makeBom` in populate-cache, but didn't see it in the 
PR description. Is that intended?



##########
dev-support/ci/populate-cache.sh:
##########
@@ -14,28 +14,23 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-#checks:basic
-
 set -u -o pipefail
 
 DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
-# from <ozone-root>/hadoop-ozone/dev-support/checks to <ozone-root>
-cd "${DIR}/../../.." || exit 1
-BASE_DIR="$(pwd -P)"
-
-CHECK=pyunit
+cd "$DIR/../.." || exit 1
 
-REPORT_DIR=${OUTPUT_DIR:-"${BASE_DIR}/target/${CHECK}"}
-mkdir -p "${REPORT_DIR}"
-
-REPORT_FILE="${REPORT_DIR}/summary.txt"
+BASE_DIR="$(pwd -P)"

Review Comment:
   nit: `BASE_DIR` seems unused?



##########
.github/workflows/populate-cache.yml:
##########
@@ -103,6 +103,13 @@ jobs:
           key: hadoop-${{ env.HADOOP_VERSION }}
           retention-days: 90
 
+      - name: Fetch Hadoop AWS dependencies
+        if: steps.restore-cache.outputs.cache-hit != 'true'
+        run: |
+          bash hadoop-ozone/dist/src/main/compose/ozone/test-s3a.sh
+        env:
+          BUILD_ONLY: true

Review Comment:
   I see [AWS SDK 
bundle](https://github.com/adoroszlai/ozone/actions/runs/44494620896/job/135458545554#step:17:13667)
 is a big one, and only `test-s3a.sh` needs it. Would a separate stash make 
sense, like the Hadoop tarball?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to