adoroszlai commented on code in PR #12101:
URL: https://github.com/apache/ozone/pull/12101#discussion_r4644260665


##########
pom.xml:
##########
@@ -3053,12 +3054,10 @@
     <profile>
       <id>go-offline</id>
       <properties>
-        <cyclonedx.skip>true</cyclonedx.skip>

Review Comment:
   I removed `cyclonedx.skip`, because in #12086 I noticed some dependencies 
were fetched by `cyclonedx` execution.  
[Example](https://github.com/adoroszlai/ozone/actions/runs/44306536135/job/134809604119#step:16:1070)
 (search for `Downloading` in the same log for few more):
   
   ```
   [INFO] --- cyclonedx:2.9.3:makeBom (default) @ hdds-common ---
   [INFO] CycloneDX: Resolving Dependencies
   [INFO] Downloading from central: 
https://repo.maven.apache.org/maven2/org/codehaus/woodstox/stax2-api/4.2/stax2-api-4.2.jar
   ```
   
   Could be a bug in `cyclonedx-plugin` or the underlying implementation of 
dependency resolution?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to