ChenSammi commented on a change in pull request #2598:
URL: https://github.com/apache/ozone/pull/2598#discussion_r700706226



##########
File path: 
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeAdminMonitorImpl.java
##########
@@ -284,9 +287,11 @@ private boolean 
checkContainersReplicatedOnNode(DatanodeDetails dn)
         if (replicaSet.isSufficientlyReplicated()) {
           sufficientlyReplicated++;
         } else {
+          underReplicatedIDs.add(cid);

Review comment:
       I added a limit of 10000 as the threshold.  From my experience of 
cluster maintenance,  I only care about the left over under replicated and 
unhealthy containers, which are of size from dozens to hundreds, so 10000 limit 
seems enough. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to