ChenSammi commented on pull request #2598: URL: https://github.com/apache/ozone/pull/2598#issuecomment-912204134
> > > > @ChenSammi when a DN is decommissioned successfully, do you think we can delete all its' replicas by sending replica delete command from SCM, so that we can free up the space on the DN and cleanup the container map of SCM. > > I don't think we should remove the containers from the DNs, for two main reasons: > > 1. Sometimes people decommission nodes for maintenance, and then bring them back to the cluster, so its better if they still have the data in that case. > > 2. If there are some bugs in decommission, then its good we can recommission the node and know its data is still intact. > > 3. If the node needs to be wiped its easy to just format the drives or delete the data folders manually later. > > I see. It makes sense to keep the replica data. > However, we should clear the replica references out of SCM. This should happen when the node goes dead, and the dead node handler runs. If that is not the case, then we might have a general problem with dead node handling. The obervation is once the DN is dead, it's replicas are all cleared from SCM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
