JacksonYao287 commented on a change in pull request #2525:
URL: https://github.com/apache/ozone/pull/2525#discussion_r705244501



##########
File path: 
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerStateManagerIntegration.java
##########
@@ -102,7 +100,7 @@ public void testAllocateContainer() throws IOException {
             SCMTestUtils.getReplicationFactor(conf), OzoneConsts.OZONE);
     ContainerInfo info = containerManager
         .getMatchingContainer(OzoneConsts.GB * 3, OzoneConsts.OZONE,
-            container1.getPipeline());
+            container1.getPipeline(), excludedContainerIDS);

Review comment:
       ```
   //V1 code , defined in ContainerManager.java
     ContainerInfo getMatchingContainer(long size, String owner,
         Pipeline pipeline);
   
   //V2 code, defined in ContainerManagerV2.java
     ContainerInfo getMatchingContainer(long size, String owner,
                                        Pipeline pipeline,
                                        Set<ContainerID> excludedContainerIDS);
   ```
   
   v1 code is not used any more, so after we remove v1 code, we could used V2 
method instead.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to