jojochuang commented on a change in pull request #2706:
URL: https://github.com/apache/ozone/pull/2706#discussion_r723739087
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
##########
@@ -383,10 +383,11 @@ private synchronized void run() {
processAll();
wait(rmConf.getInterval());
}
- } catch (Throwable t) {
+ } catch (InterruptedException t) {
Review comment:
let's not change it here.
catching a Throwable here is intentional: we want to log an error message
and ensure the process get killed even when there's an unchecked exception (for
example, NullPointerException)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
