jojochuang commented on a change in pull request #2706:
URL: https://github.com/apache/ozone/pull/2706#discussion_r724653252
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/PipelineSyncTask.java
##########
@@ -76,8 +76,10 @@ protected synchronized void run() {
recordSingleRunCompletion();
wait(interval);
}
- } catch (Throwable t) {
Review comment:
catch Throwable in a run() is intentional so we can see when a thread
exits.
let's try this instead:
```
} catch (Throwable t) {
LOG.error("Exception in Pipeline sync Thread.", t);
if (t instanceof InterruptedException) {
Thread.currentThread().interrupt();
}
```
Of course, this is not necessary because the thread is to be terminated
anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
