fapifta commented on a change in pull request #2767:
URL: https://github.com/apache/ozone/pull/2767#discussion_r741499267
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java
##########
@@ -239,7 +293,15 @@ private void handleParityWrites(int parityCellSize,
// TODO: we should alter the put block calls to share CRC to each stream.
ECBlockOutputStreamEntry streamEntry =
blockOutputStreamEntryPool.getCurrentStreamEntry();
+ // Since writes are async, let's check the failures once.
+ if(streamEntry.checkStreamFailures()){
Review comment:
With this call, we are synchronising on parity write, and we loose the
async nature of the write on this front as well. We discussed today that the
grpc client does not do writes async, if we fix that, then we still loose async
writes as parity writes become synced. I believe this we should record as a
future improvement here, as handling the rewrite of the stripe in a more async
manner would probably require a significant change in how we buffer data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
