fapifta commented on a change in pull request #2767:
URL: https://github.com/apache/ozone/pull/2767#discussion_r741971338
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/ECBlockOutputStream.java
##########
@@ -35,12 +38,15 @@
import java.util.concurrent.ExecutionException;
import static
org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.putBlockAsync;
+import static
org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.writeChunkAsync;
/**
* Handles the chunk EC writes for an EC internal block.
*/
public class ECBlockOutputStream extends BlockOutputStream{
+ private CompletableFuture<ContainerProtos.ContainerCommandResponseProto>
+ currentChunkRspFuture = null;
Review comment:
Ah, if flushes won't be supported, then probably this is not a problem,
as executePutBlock than will happen after evaluating the future in writes (due
to the sync nature of how we test for failures). I can live with this, though I
still wondering if it would be safer to use two references one to store futures
from wirtes, and one from putBlock, and check for both in the failure check,
though I do not have any case in mind atm without flush where this would be a
real problem in the current system, so I am ok with leaving this as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
