lokeshj1703 commented on a change in pull request #2786:
URL: https://github.com/apache/ozone/pull/2786#discussion_r749963553
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -731,6 +738,24 @@ boolean canSizeEnterTarget(DatanodeDetails target, long
size) {
return potentialTargets;
}
+ /**
+ * Consults the configurations {@link ContainerBalancer#includeNodes} and
+ * {@link ContainerBalancer#excludeNodes} to check if the specified
+ * Datanode should be excluded from balancing.
+ * @param datanode DatanodeDetails to check
+ * @return true if Datanode should be excluded, else false
+ */
+ boolean shouldExcludeDatanode(DatanodeDetails datanode) {
Review comment:
I think we should throw an IllegalArgumentsException. Otherwise it can
be categorised as inconsistent behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
