siddhantsangwan commented on a change in pull request #2786:
URL: https://github.com/apache/ozone/pull/2786#discussion_r751905828
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -731,6 +738,24 @@ boolean canSizeEnterTarget(DatanodeDetails target, long
size) {
return potentialTargets;
}
+ /**
+ * Consults the configurations {@link ContainerBalancer#includeNodes} and
+ * {@link ContainerBalancer#excludeNodes} to check if the specified
+ * Datanode should be excluded from balancing.
+ * @param datanode DatanodeDetails to check
+ * @return true if Datanode should be excluded, else false
+ */
+ boolean shouldExcludeDatanode(DatanodeDetails datanode) {
Review comment:
According to our latest discussion, in which the following points were
identified:
- We can recover from this scenario by excluding the node. In the worst
case, this will lead to the exclusion of a datanode that the user actually
wanted to include.
- HDFS Balancer excludes the datanode if it's mentioned in both include and
exclude lists.
Let's exclude the datanode from balancing in this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
