kerneltime commented on a change in pull request #2822:
URL: https://github.com/apache/ozone/pull/2822#discussion_r750767587
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -2601,6 +2592,10 @@ public OzoneManagerHttpServer getHttpServer() {
ServiceInfo.Builder peerOmServiceInfoBuilder = ServiceInfo.newBuilder()
.setNodeType(HddsProtos.NodeType.OM)
.setHostname(peerNode.getHostName())
+ // For now assume peer is at the same version.
+ // This field needs to be fetched from peer when rolling upgrades
+ // are implemented.
+ .setOmClientProtocolVersion(OZONE_OM_CLIENT_PROTOCOL_VERSION)
Review comment:
Server is setting the protocol version that it supports for clients. OM
client protocol is the protocol between OM and the client as supported by the
OM.
OM has a hard coded value that is decided at compile time based on the
config set in code. This string is also made available on the client side to
change based on the `OZONE_OM_CLIENT_PROTOCOL_VERSION_KEY`. Right now client
will talk only if the version it expects is present, we should support being
able to have multiple versions as part of the spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
