bharatviswa504 commented on a change in pull request #2822:
URL: https://github.com/apache/ozone/pull/2822#discussion_r750779275
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -200,6 +199,22 @@ public RpcClient(ConfigurationSource conf, String
omServiceId)
// requests serviced by this client will need S3 Auth set.
ozoneManagerProtocolClientSideTranslatorPB.setS3AuthCheck(
conf.getBoolean(S3Auth.S3_AUTH_CHECK, false));
+ String omVersion = conf.get(OZONE_OM_CLIENT_PROTOCOL_VERSION_KEY);
Review comment:
>We need the actual version string, going forward we can have higher
versions so the presence is not enough.
For now we should be good in the scenario if it has the value. And as said
old client talking to new server and new client talking to old server should be
supported. So, technically clients based on version returned by server and not
talking i think we donot need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
