JacksonYao287 commented on a change in pull request #2808:
URL: https://github.com/apache/ozone/pull/2808#discussion_r751147870
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -341,99 +341,59 @@ private boolean initializeIteration() {
nodeManager, replicationManager, containerManager);
sourceToTargetMap = new HashMap<>(overUtilizedNodes.size() +
withinThresholdUtilizedNodes.size());
-
- // initialize maps to track how much size is leaving and entering datanodes
- sizeLeavingNode = new HashMap<>(overUtilizedNodes.size() +
- withinThresholdUtilizedNodes.size());
- overUtilizedNodes.forEach(datanodeUsageInfo -> sizeLeavingNode
- .put(datanodeUsageInfo.getDatanodeDetails(), 0L));
- withinThresholdUtilizedNodes.forEach(datanodeUsageInfo -> sizeLeavingNode
- .put(datanodeUsageInfo.getDatanodeDetails(), 0L));
-
- sizeEnteringNode = new HashMap<>(underUtilizedNodes.size() +
- withinThresholdUtilizedNodes.size());
- underUtilizedNodes.forEach(datanodeUsageInfo -> sizeEnteringNode
- .put(datanodeUsageInfo.getDatanodeDetails(), 0L));
- withinThresholdUtilizedNodes.forEach(datanodeUsageInfo -> sizeEnteringNode
- .put(datanodeUsageInfo.getDatanodeDetails(), 0L));
-
return true;
}
private IterationResult doIteration() {
// note that potential and selected targets are updated in the following
// loop
- List<DatanodeDetails> potentialTargets = getPotentialTargets();
+ //TODO(jacksonyao): take withinThresholdUtilizedNodes as candidate for both
+ // source and target
+ findSourceStrategy.reInitialize(getPotentialSources(), config, lowerLimit);
+ List<DatanodeUsageInfo> potentialTargets = getPotentialTargets();
+ findTargetStrategy.reInitialize(potentialTargets, config, upperLimit);
Review comment:
> Is this required for recalculating limits and other metadata in a
later PR?
yea, it is. so think we can keep it here in this PR, and i will deal with it
in the later coming PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
