JacksonYao287 commented on pull request #2808: URL: https://github.com/apache/ozone/pull/2808#issuecomment-968784537
thanks @lokeshj1703 and @siddhantsangwan for the review! >1. I was thinking we should have sth similar to FindTargetStrategy for source like FindSourceStrategy. we can add an interface of FindSourceStrategy and add a default implementation for it. this can be done by refactoring `SourceDataNodeSelectionCriteria`. >2. Let's have a separate PR for withinThreshold nodes removal. I think there was a use case where accounting them was important where there are 5 over utilized and 5 within threshold nodes. sure, let us create another to solve this, and fix related bug. in this patch , we focus supporting multiple container moves from a source datanode. i will add withinThreshold nodes back in a new commit >3. Also by default we shouldn't allow all size of data to be moved from source/target. It is important to limit otherwise it is possible for all balancing to happen in 2-4 nodes. in this patch , before matching a target with a source , we will sort all the target datanodes In ascending order and all the source datanodes in descending order by usage rate considering `SizeEnteringnode` and `SizeLeavingNode`, so that we always try to match a source datanode with the biggest usage to the target datanode with a smallest usage. it is Almost impossible for all balancing to happen in only 2-4 nodes， unless those 2-4 nodes has a much bigger or smaller usage than others. i think if that case happens, it makes sense to move only among these Very unbalanced datanodes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
