smengcl commented on a change in pull request #2857:
URL: https://github.com/apache/ozone/pull/2857#discussion_r765232391
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/tenant/TenantCreateHandler.java
##########
@@ -17,42 +17,33 @@
*/
package org.apache.hadoop.ozone.shell.tenant;
-import org.apache.hadoop.hdds.cli.GenericCli;
import org.apache.hadoop.ozone.client.OzoneClient;
import org.apache.hadoop.ozone.shell.OzoneAddress;
import picocli.CommandLine;
import java.io.IOException;
-import java.util.ArrayList;
-import java.util.List;
/**
* ozone tenant create.
*/
@CommandLine.Command(name = "create",
- description = "Create one or more tenants")
+ description = "Create a tenant."
+ + " This will also create a new Ozone volume for the tenant.")
public class TenantCreateHandler extends TenantHandler {
- @CommandLine.Spec
- private CommandLine.Model.CommandSpec spec;
-
- @CommandLine.Parameters(description = "List of tenant names")
- private List<String> tenants = new ArrayList<>();
+ @CommandLine.Parameters(description = "Tenant name", arity = "1..1")
+ private String tenantId;
@Override
protected void execute(OzoneClient client, OzoneAddress address) {
- if (tenants.size() > 0) {
- for (String tenantName : tenants) {
- try {
- client.getObjectStore().createTenant(tenantName);
- out().println("Created tenant '" + tenantName + "'.");
- } catch (IOException e) {
- err().println("Failed to create tenant '" + tenantName + "': " +
- e.getMessage());
- }
- }
- } else {
- GenericCli.missingSubcommand(spec);
+ try {
+ client.getObjectStore().createTenant(tenantId);
+ // TODO: Add return value and print volume name?
+ out().println("Created tenant '" + tenantId + "'.");
+ } catch (IOException e) {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
