smengcl commented on a change in pull request #2857:
URL: https://github.com/apache/ozone/pull/2857#discussion_r765236238
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantRequestHelper.java
##########
@@ -94,26 +99,26 @@ static void checkTenantExistence(OMMetadataManager
omMetadataManager,
* Retrieve volume name of the tenant.
*/
static String getTenantVolumeName(OMMetadataManager omMetadataManager,
- String tenantName) {
+ String tenantId) {
final OmDBTenantInfo tenantInfo;
try {
- tenantInfo = omMetadataManager.getTenantStateTable().get(tenantName);
+ tenantInfo = omMetadataManager.getTenantStateTable().get(tenantId);
} catch (IOException e) {
throw new RuntimeException("Potential DB error. Unable to retrieve "
- + "OmDBTenantInfo entry for tenant '" + tenantName + "'.");
+ + "OmDBTenantInfo entry for tenant '" + tenantId + "'.");
Review comment:
`OMClientRequest#validateAndUpdateCache` doesn't really propagate any
exception.
To throw IOException in this helper method I'd have to add extra try logic
in `validateAndUpdateCache` to handle it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
