symious commented on pull request #2893: URL: https://github.com/apache/ozone/pull/2893#issuecomment-990672711
@siddhantsangwan Thanks for the review. Yes, and in fact the other initialize method seems a little odd. I added the method because the original ContainerBalancerConfiguration is constructed with OzoneConfiguration, which is to override those configurations on purpose. I think the root problem is that some values of ContainerBalancerConfiguration are dependent on other configurations, like "size.entering.target.max" is depending on "OZONE_SCM_CONTAINER_SIZE_DEFAULT", but the current ConfigGroup annotation doesn't support this requirement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
