symious commented on pull request #2893: URL: https://github.com/apache/ozone/pull/2893#issuecomment-994639933
@siddhantsangwan @JacksonYao287 Thanks for the reply. I think Option 1 is the original implementation. If we initialize ContainerBalancerConfiguration based on OzoneConfiguration, the @ConfigGroup pattern won't work, that is the content of ozone-site.xml won't be projected to ContainerBalancerConfiguration. AFAIK, we need to use ozoneConfiguration.getObject(ContainerBalancerConfiguration.class) to load the value from ozone-site.xml. I think Option 3 might be a good choice. We can let ContainerBalancerConfiguration only handle the configs from ozone-site.xml, the validation and check of configs can be handled when starting container balancer service.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
