bharatviswa504 commented on pull request #2886:
URL: https://github.com/apache/ozone/pull/2886#issuecomment-996316512
> Thanks for the review Bharat.
>
> > Do we want to allow only operation at a time on this operation? And
throw exception to other invokes on this API from client Like Already remove is
ongoing something like this.
> > Coming from the perspective of one cli remove om1, and another cli
remove om2. If we know inprogress thing, we can ask for 2nd invocation retry
once after first is completed. Do we need any such semantics here?
>
> Missed this earlier. Yes, it would be good to have this. But since the
SetConfiguration will be synchronized from Ratis side, it is not critical that
we control it from Ozone side as well. A simple way to handle this would be to
fail the request on getting ReconfigurationInProgressException. This way we can
throw the error upto the cli and ask to retry. What do you think?
Yes good idea, i think this can also be taken as part of HDDS-5847, as we
need changes in failOverProxyProvider for that to fail when
ReconfigurationInProgressException is received.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
