hanishakoneru commented on a change in pull request #2886:
URL: https://github.com/apache/ozone/pull/2886#discussion_r770986685
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OMAdminProtocolClientSideImpl.java
##########
@@ -123,12 +175,48 @@ public OMConfiguration getOMConfiguration() throws
IOException {
}
return omMedatataBuilder.build();
} catch (ServiceException e) {
- LOG.error("Failed to retrieve configuration of OM {}",
- remoteOmNodeDetails.getOMPrintInfo(), e);
+ LOG.error("Failed to retrieve configuration of OM {}", omPrintInfo, e);
}
return null;
}
+ @Override
+ public void decommission(OMNodeDetails removeOMNode) throws IOException {
+ DecommissionOMRequest decommOMRequest = DecommissionOMRequest.newBuilder()
+ .setNodeId(removeOMNode.getNodeId())
+ .setNodeAddress(removeOMNode.getHostAddress())
+ .build();
+
+ DecommissionOMResponse response;
+ try {
+ response = rpcProxy.decommission(NULL_RPC_CONTROLLER, decommOMRequest);
Review comment:
Good catch Bharat.. I can update the
OMFailoverProxyProvider#getRetryPolicy() to include this condition for
ReconfigurationInProgressException. But this condition need not be checked for
regular client requests.
So I was thinking we should improve the retry policy to be specific for each
protocol instead of a generic one. There is a Jira (HDDS-5847) open for adding
a separate failover proxy for OMInterServiceProtocol
(ReconfigurationInProgressException is valid for inter service protocol too). I
can update this along with that, if you are ok with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
