symious commented on a change in pull request #2893:
URL: https://github.com/apache/ozone/pull/2893#discussion_r775093563
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -752,6 +754,31 @@ public void stop() {
LOG.info("Container Balancer stopped successfully.");
}
+ private void validateConfiguration(ContainerBalancerConfiguration conf) {
+ // maxSizeEnteringTarget and maxSizeLeavingSource should by default be
+ // greater than container size
+ long size = (long) ozoneConfiguration.getStorageSize(
+ ScmConfigKeys.OZONE_SCM_CONTAINER_SIZE,
+ ScmConfigKeys.OZONE_SCM_CONTAINER_SIZE_DEFAULT, StorageUnit.BYTES);
+
+ if (conf.getMaxSizeEnteringTarget() <= size) {
+ LOG.info("MaxSizeEnteringTarget should be larger than " +
+ "ozone.scm.container.size");
+ }
+ if (conf.getMaxSizeLeavingSource() <= size) {
+ LOG.info("MaxSizeLeavingSource should be larger than " +
+ "ozone.scm.container.size");
+ }
+
+ // balancing interval should be greater than DUFactory refresh period
+ DUFactory.Conf duConf = ozoneConfiguration.getObject(DUFactory.Conf.class);
+ long balancingInterval = duConf.getRefreshPeriod().toMillis();
+ if (conf.getBalancingInterval().toMillis() <= balancingInterval) {
+ LOG.info("balancing.iteration.interval should be larger than " +
+ "hdds.datanode.du.refresh.period.");
+ }
Review comment:
Yes, it was intended to return "false" for these situations, but it will
break many test cases.
The changes will be brought up in a new ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
