siddhantsangwan commented on pull request #2893: URL: https://github.com/apache/ozone/pull/2893#issuecomment-997640302
> @siddhantsangwan Update the commit. Could you help to check? > > Added validateConfiguration in ContainerBalancer, it can return boolean to indicate an incorrect configuration, but many changes in test cases need to be made, for now, I leave the method to be void. Yes, having it return a boolean makes sense. And sure, we can add this change in a follow-up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
