rakeshadr commented on a change in pull request #2919: URL: https://github.com/apache/ozone/pull/2919#discussion_r778540688
########## File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/BaseFileChecksumHelper.java ########## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.client; + +import com.google.common.annotations.VisibleForTesting; +import org.apache.hadoop.fs.FileChecksum; +import org.apache.hadoop.fs.MD5MD5CRC32GzipFileChecksum; +import org.apache.hadoop.hdds.scm.XceiverClientFactory; +import org.apache.hadoop.io.DataOutputBuffer; +import org.apache.hadoop.io.MD5Hash; +import org.apache.hadoop.ozone.client.protocol.ClientProtocol; +import org.apache.hadoop.ozone.client.rpc.RpcClient; +import org.apache.hadoop.ozone.om.helpers.OmKeyArgs; +import org.apache.hadoop.ozone.om.helpers.OmKeyInfo; +import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo; +import org.apache.hadoop.ozone.om.protocol.OzoneManagerProtocol; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.List; + +/** + * The base class to support file checksum. + */ +public abstract class BaseFileChecksumHelper { + static final Logger LOG = + LoggerFactory.getLogger(BaseFileChecksumHelper.class); + + private OzoneVolume volume; + private OzoneBucket bucket; + private String keyName; + private final long length; + private ClientProtocol rpcClient; + + private XceiverClientFactory xceiverClientFactory; + private final DataOutputBuffer blockChecksumBuf = new DataOutputBuffer(); + private FileChecksum fileChecksum; + private List<OmKeyLocationInfo> keyLocationInfos; + private long remaining = 0L; + private int bytesPerCRC = -1; + private long crcPerBlock = 0; + + // initialization + BaseFileChecksumHelper( + OzoneVolume volume, OzoneBucket bucket, String keyName, + long length, ClientProtocol rpcClient) throws IOException { + + this.volume = volume; + this.bucket = bucket; + this.keyName = keyName; + this.length = length; + this.rpcClient = rpcClient; + this.xceiverClientFactory = + ((RpcClient)rpcClient).getXceiverClientManager(); + refetchBlocks(); + } + + protected String getSrc() { + return "Volume: " + volume.getName() + " Bucket: " + bucket.getName() + " " + + keyName; + } + + protected long getLength() { + return length; + } + + protected ClientProtocol getRpcClient() { + return rpcClient; + } + + protected XceiverClientFactory getXceiverClientFactory() { + return xceiverClientFactory; + } + + protected DataOutputBuffer getBlockChecksumBuf() { + return blockChecksumBuf; + } + + protected List<OmKeyLocationInfo> getKeyLocationInfoList() { + return keyLocationInfos; + } + + protected long getRemaining() { + return remaining; + } + + protected void setRemaining(long remaining) { + this.remaining = remaining; + } + + int getBytesPerCRC() { + return bytesPerCRC; + } + + protected void setBytesPerCRC(int bytesPerCRC) { + this.bytesPerCRC = bytesPerCRC; + } + + /** + * Request the blocks created in the most recent version from Ozone Manager. + * + * @throws IOException + */ + private void refetchBlocks() throws IOException { Review comment: Since we don't have `isRefetchBlocks` flag in place, how about renaming the method to `fetchBlocks` to reflect the functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
