rakeshadr commented on a change in pull request #2919: URL: https://github.com/apache/ozone/pull/2919#discussion_r778583948
########## File path: hadoop-ozone/client/src/test/java/org/apache/hadoop/ozone/client/TestReplicatedFileChecksumHelper.java ########## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.client; + +import org.apache.hadoop.fs.FileChecksum; +import org.apache.hadoop.fs.MD5MD5CRC32GzipFileChecksum; +import org.apache.hadoop.hdds.client.BlockID; +import org.apache.hadoop.hdds.client.RatisReplicationConfig; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos; +import org.apache.hadoop.hdds.scm.XceiverClientFactory; +import org.apache.hadoop.hdds.scm.XceiverClientGrpc; +import org.apache.hadoop.hdds.scm.XceiverClientReply; +import org.apache.hadoop.hdds.scm.pipeline.Pipeline; +import org.apache.hadoop.hdds.scm.pipeline.PipelineID; +import org.apache.hadoop.ozone.client.rpc.RpcClient; +import org.apache.hadoop.ozone.om.helpers.OmKeyInfo; +import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfo; +import org.apache.hadoop.ozone.om.helpers.OmKeyLocationInfoGroup; +import org.apache.hadoop.ozone.om.protocol.OzoneManagerProtocol; +import org.apache.hadoop.util.DataChecksum; +import org.apache.hadoop.util.Time; +import org.apache.ratis.thirdparty.com.google.protobuf.ByteString; +import org.junit.Test; +import org.mockito.Mockito; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.UUID; +import java.util.concurrent.CompletableFuture; + +import static org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos.ChecksumType.CRC32; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.when; + +/** + * Unit tests for ReplicatedFileChecksumHelper class. + */ +public class TestReplicatedFileChecksumHelper { + + @Test + public void testEmptyBlock() throws IOException { + // test the file checksum of a file with an empty block. + RpcClient rpcClient = Mockito.mock(RpcClient.class); + + OzoneManagerProtocol om = Mockito.mock(OzoneManagerProtocol.class); + when(rpcClient.getOzoneManagerClient()).thenReturn(om); + + OmKeyInfo omKeyInfo = new OmKeyInfo.Builder() + .setVolumeName(null) + .setBucketName(null) + .setKeyName(null) + .setOmKeyLocationInfos(Collections.singletonList( + new OmKeyLocationInfoGroup(0, new ArrayList<>()))) + .setCreationTime(Time.now()) + .setModificationTime(Time.now()) + .setDataSize(0) + .setReplicationConfig(new RatisReplicationConfig( + HddsProtos.ReplicationFactor.ONE)) + .setFileEncryptionInfo(null) + .setAcls(null) + .build(); + + when(om.lookupKey(any())).thenReturn(omKeyInfo); + + OzoneVolume volume = Mockito.mock(OzoneVolume.class); + when(volume.getName()).thenReturn("vol1"); + OzoneBucket bucket = Mockito.mock(OzoneBucket.class); + when(bucket.getName()).thenReturn("bucket1"); + + ReplicatedFileChecksumHelper helper = new ReplicatedFileChecksumHelper( + volume, bucket, "dummy", 10, rpcClient); + helper.compute(); + FileChecksum fileChecksum = helper.getFileChecksum(); + assertTrue(fileChecksum instanceof MD5MD5CRC32GzipFileChecksum); + assertEquals(DataChecksum.Type.CRC32, + ((MD5MD5CRC32GzipFileChecksum)fileChecksum).getCrcType()); + } + + @Test + public void testOneBlock() throws IOException { Review comment: Thanks for the good test case. Since this is primary patch I agree to keep it simple here and push this patch in asap. Adding a note here for including more test cases in follow-up jira tasks. I'd to to add more test cases with variable length values(-1, 0, >0), with more blocks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
