rakeshadr commented on a change in pull request #2935:
URL: https://github.com/apache/ozone/pull/2935#discussion_r780898440
##########
File path:
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/OzoneClientUtils.java
##########
@@ -64,4 +72,19 @@ public static BucketLayout
resolveLinkBucketLayout(OzoneBucket bucket,
}
return bucket.getBucketLayout();
}
+
+ public static FileChecksum getFileChecksumWithCombineMode(OzoneVolume volume,
+ OzoneBucket bucket, String keyName, long length,
+ Options.ChecksumCombineMode combineMode, ClientProtocol rpcClient)
+ throws IOException {
+ Preconditions.checkArgument(length >= 0);
+
+ if (keyName.length() == 0) {
Review comment:
Can you add test for the following cases:
```
testcase-1) Length < 0
testcase-2) keyName.length() <= 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
