rakeshadr commented on a change in pull request #2935:
URL: https://github.com/apache/ozone/pull/2935#discussion_r787330525
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java
##########
@@ -124,6 +125,15 @@
tags = ConfigTag.CLIENT)
private boolean checksumVerify = true;
+ @Config(key = "checksum.combine.mode",
+ defaultValue = "MD5MD5CRC",
+ description = "The combined checksum type [MD5MD5CRC / COMPOSITE_CRC] "
+ + "determines which algorithm would be used to compute checksum for "
+ + "file checksum. Default checksum type is MD5MD5CRC.",
+ tags = ConfigTag.CLIENT)
+ private String checksumCombineMode =
+ Options.ChecksumCombineMode.MD5MD5CRC.name();
Review comment:
Please make the default value to COMPOSITE_CRC. I think it makes more
meaningful in Ozone because the ask to implement #getFileChecksum() API came
from replication work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
