fapifta opened a new pull request #2979: URL: https://github.com/apache/ozone/pull/2979
## What changes were proposed in this pull request? Added an extensive documentation about the gRPC client code that we have for reads, and also we are using for EC writes already in the EC development branch. This documentation justifies as well the changes proposed in the XCeiverClientGrpc class. The changes are: - enable async write operations used by WriteChunk and PutBlock operations in the EC branch, and nowhere else. - cleanup TODO comments - Fix some of the code warnings - Updated related javadoc Some of the wording in the documentation contains information about the current EC development status, these to be updated once we have merged the EC code to the master branch. For now they are there to help understand some of the internals that are relevant for the write requests, and for the decisions made about how to resolve the TODO items that are removed from the XCeiverClientGrpc class as they are considered to be resolved, or abandoning of them is justified in the documentation. As the changes does not have any visible effect on how the master branch works, I am proposing to merge this change to the master branch directly, to ease the EC branch merge work later. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-5954 ## How was this patch tested? Same JUnit tests should cover the behaviour in the master branch as before, as changes are not affecting the logic used in the current codebase. In EC branch, I have tried to run our current tests, and I have not seen issues to appear, the only logical change should have an effect in the EC write path, and is covered with EC tests and backed up by external synchronization points in the EC code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
