fapifta commented on a change in pull request #2979:
URL: https://github.com/apache/ozone/pull/2979#discussion_r790886932
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -70,28 +70,41 @@
import static org.apache.hadoop.hdds.HddsUtils.processForDebug;
/**
- * A Client for the storageContainer protocol for read object data.
+ * {@link XceiverClientSpi} implementation, the standalone client.
+ *
+ * This class can be used to connect to a DataNode and use the
+ * DatanodeClientProtocol to read and write data.
+ * Writes via this client does not go through the Ratis protocol, and does not
+ * replicate to any other nodes, usage of this client implementation to
+ * write replicated data is ill-advised.
+ *
+ * When using the sendCommandAsync method, the client code need to ensure
Review comment:
removed this clause, as we need to leave the original client this way,
and we should specialize the implementation for EC only, as Standalone client
is still not deprecated for writes, and we should not change its semantics
directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
