adoroszlai commented on a change in pull request #2983:
URL: https://github.com/apache/ozone/pull/2983#discussion_r785050062
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerData.java
##########
@@ -225,11 +226,11 @@ public long getMaxSize() {
}
/**
- * Returns the layOutVersion of the actual container data format.
- * @return layOutVersion
+o * Returns the layoutVersion of the actual container data format.
Review comment:
Stray character:
```suggestion
* Returns the layoutVersion of the actual container data format.
```
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerData.java
##########
@@ -129,19 +129,20 @@
* Creates a ContainerData Object, which holds metadata of the container.
* @param type - ContainerType
* @param containerId - ContainerId
- * @param layOutVersion - Container layOutVersion
+ * @param layoutVersion - Container layoutVersion
* @param size - Container maximum size in bytes
* @param originPipelineId - Pipeline Id where this container is/was created
* @param originNodeId - Node Id where this container is/was created
*/
protected ContainerData(ContainerType type, long containerId,
- ChunkLayOutVersion layOutVersion, long size, String originPipelineId,
- String originNodeId) {
+ ContainerLayoutVersion layoutVersion, long size,
+ String originPipelineId,
+ String originNodeId) {
Preconditions.checkNotNull(type);
this.containerType = type;
this.containerID = containerId;
- this.layOutVersion = layOutVersion.getVersion();
+ this.layOutVersion = layoutVersion.getVersion();
Review comment:
Nit: Please also rename `this.layOutVersion` to `this.layoutVersion`.
Also in `DatanodeVersionFile`.
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerDataYaml.java
##########
@@ -252,8 +252,9 @@ public Object construct(Node node) {
//Needed this, as TAG.INT type is by default converted to Long.
long layOutVersion = (long) nodes.get(OzoneConsts.LAYOUTVERSION);
Review comment:
Nit: for consistency.
```suggestion
long layoutVersion = (long) nodes.get(OzoneConsts.LAYOUTVERSION);
```
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerDataYaml.java
##########
@@ -252,8 +252,9 @@ public Object construct(Node node) {
//Needed this, as TAG.INT type is by default converted to Long.
long layOutVersion = (long) nodes.get(OzoneConsts.LAYOUTVERSION);
- ChunkLayOutVersion layoutVersion =
- ChunkLayOutVersion.getChunkLayOutVersion((int) layOutVersion);
+ ContainerLayoutVersion layoutVersion =
+ ContainerLayoutVersion.getContainerLayoutVersion(
+ (int) layOutVersion);
Review comment:
Nit: for consistency.
```suggestion
(int) layoutVersion);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
