JyotinderSingh commented on a change in pull request #2983:
URL: https://github.com/apache/ozone/pull/2983#discussion_r785079130
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerData.java
##########
@@ -129,19 +129,20 @@
* Creates a ContainerData Object, which holds metadata of the container.
* @param type - ContainerType
* @param containerId - ContainerId
- * @param layOutVersion - Container layOutVersion
+ * @param layoutVersion - Container layoutVersion
* @param size - Container maximum size in bytes
* @param originPipelineId - Pipeline Id where this container is/was created
* @param originNodeId - Node Id where this container is/was created
*/
protected ContainerData(ContainerType type, long containerId,
- ChunkLayOutVersion layOutVersion, long size, String originPipelineId,
- String originNodeId) {
+ ContainerLayoutVersion layoutVersion, long size,
+ String originPipelineId,
+ String originNodeId) {
Preconditions.checkNotNull(type);
this.containerType = type;
this.containerID = containerId;
- this.layOutVersion = layOutVersion.getVersion();
+ this.layOutVersion = layoutVersion.getVersion();
Review comment:
The variable name `layOutVersion` is tightly coupled with the name of
the key inside the container data YAML file. Renaming this to `layoutVersion`
will change the key persisted into the YAML to `"layoutVersion"` as well
(potentially breaking backward compatibility).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
