fapifta commented on pull request #2987: URL: https://github.com/apache/ozone/pull/2987#issuecomment-1021184266
Thank you @dombizita to address my comments, I still have one thing that has to be solved, and one suggestion regarding the constant names. The problematic one I added as an additional inline command around configuration and secondary client creation. With the constants, I would do one more thing, I would try to add a bit more descriptive names, like: JSON_PROPERTY_FILE_NAME JSON_PROPERTY_FILE_SIZE JSON_PROPERTY_FILE_BLOCKS JSON_PROPERTY_BLOCKS_INDEX JSON_PROPERTY_BLOCKS_CONTAINERID ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
