dombizita commented on pull request #2987: URL: https://github.com/apache/ozone/pull/2987#issuecomment-1021081782
> Hi Zita, thank you for contributing this new debug tool, I would like to request one general thing, and also I have a few comments inline. > > I would generally suggest to create String constants and put them at the top of the class, for property names used in the manifest file, it would make it easier to see what properties we expect to have in the manifest if they are at one place. This is a stylistic suggestion, I can accept the current code in this regard, so I let this change for you to decide if it is worth it. Hi @fapifta, thank you so much for the review. I have taken your advices and changed the mentioned things. I also created the String constants, the code is much clearer this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
