sodonnel commented on a change in pull request #3032:
URL: https://github.com/apache/ozone/pull/3032#discussion_r797470936
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##########
@@ -934,9 +929,17 @@ public boolean isBucketEmpty(String volume, String bucket)
// Entry should not be marked for delete, consider only those
// entries.
- if(!deletedKeySet.contains(kv.getKey())) {
- cacheKeyMap.put(kv.getKey(), kv.getValue());
- currentCount++;
+ String key = kv.getKey();
Review comment:
With the change you have made here, to check the cache for each entry
returned from the rockdb table iterator, do we need the `cacheKeyMap` and the
earlier loop to pull all the cached entries into it? Could we simply iterate
the RocksDB, check the cache for deleted values and add the valid entries to
the result list?
Or, is it possible for there to be entries in the cache, which are not
deleted entreis, that are not in RocksDB somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
