sodonnel commented on a change in pull request #3032:
URL: https://github.com/apache/ozone/pull/3032#discussion_r798492376



##########
File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##########
@@ -965,23 +964,27 @@ public boolean isBucketEmpty(String volume, String bucket)
 
     // Clear map and set.
     cacheKeyMap.clear();
-    deletedKeySet.clear();
 
     return result;
   }
 
   // TODO: HDDS-2419 - Complete stub below for core logic
   @Override
-  public List<RepeatedOmKeyInfo> listTrash(String volumeName, String 
bucketName,
-      String startKeyName, String keyPrefix, int maxKeys) throws IOException {
+  public List<RepeatedOmKeyInfo> listTrash(String volumeName,

Review comment:
       It would be better to revert these formatting changes. The "Ozone style" 
seems to be more like the unchanged version, and these sort of changes can 
cause conflicts etc later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to