sodonnel opened a new pull request #3033:
URL: https://github.com/apache/ozone/pull/3033


   ## What changes were proposed in this pull request?
   
   The replication config, which includes type and factor is already present in 
the Json output. The getters for ContainerInfo:
   
   ```
   getReplicationType()
   getReplicationFactor()
   ```
   Therefore do not need to be displayed in the JSON output, as they duplicate 
the replication config information.
   
   Additionally, EC containers do not have a "factor" which causes an error 
when the JSON is displayed:
   
   ```
   bash-4.2$ ozone admin container info --json 4      
   Replication configuration of type EC does not have a replication factor 
property. (through reference chain: 
org.apache.hadoop.hdds.scm.container.common.helpers.ContainerWithPipeline["containerInfo"]->org.apache.hadoop.hdds.scm.container.ContainerInfo["replicationFactor"])
   ```
   
   This change simply removes the two getters from the JSON output.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-6240
   
   ## How was this patch tested?
   
   Existing test - no logic changed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to