sodonnel commented on a change in pull request #3033:
URL: https://github.com/apache/ozone/pull/3033#discussion_r797769662
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerInfo.java
##########
@@ -154,10 +154,12 @@ public ReplicationConfig getReplicationConfig() {
return replicationConfig;
}
Review comment:
In the json output from the command "replicationFactor" and
"replicationType" will no longer be output, as they are duplicated inside
replicationConfig: { type: ... factor ... }.
For a command like this, I don't think it makes sense to keep the old
version now we have replicationConfig instead.
It would significantly complicate things to optionally output these fields
in the json depending if we have Ratis or EC, as right now the JSON helper
outputs all getters on the object, unless we ignore them as in this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
