errose28 commented on a change in pull request #3018:
URL: https://github.com/apache/ozone/pull/3018#discussion_r797950247
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/multitenant/TestMultiTenantVolume.java
##########
@@ -77,14 +89,81 @@ public void testDefaultS3Volume() throws Exception {
assertS3BucketNotFound(store, bucketName);
}
+ private void expectFailurePreFinalization(VoidCallable eval)
+ throws Exception {
+ LambdaTestUtils.intercept(OMException.class,
+ "cannot be invoked before finalization", eval);
+ }
+
+ /**
+ * Perform sanity checks before triggering upgrade finalization.
+ */
+ private void preFinalizationCheck(ObjectStore store, String tenant,
Review comment:
I missed this the first time looking through, but since we are sharing a
cluster to save time, we should make sure the upgrade happens before either of
the two tests, because we want `testDefaultS3Volume` to run on the finalized
version as well. Maybe we can make the upgrade steps their own test, and define
an order for the tests. Since we are using junit4, I think this would have to
be done with `@FixMethodOrder(MethodSorters.NAME_ASCENDING)`, and adding a
prefix to the test names to indicate their order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
