smengcl commented on a change in pull request #3018:
URL: https://github.com/apache/ozone/pull/3018#discussion_r799112078
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/multitenant/TestMultiTenantVolume.java
##########
@@ -77,14 +89,81 @@ public void testDefaultS3Volume() throws Exception {
assertS3BucketNotFound(store, bucketName);
}
+ private void expectFailurePreFinalization(VoidCallable eval)
+ throws Exception {
+ LambdaTestUtils.intercept(OMException.class,
+ "cannot be invoked before finalization", eval);
+ }
+
+ /**
+ * Perform sanity checks before triggering upgrade finalization.
+ */
+ private void preFinalizationCheck(ObjectStore store, String tenant,
Review comment:
Good point.
I like the idea of moving the pre-finalization checks to the cluster setup
stage. Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
