adoroszlai opened a new pull request #3061: URL: https://github.com/apache/ozone/pull/3061
## What changes were proposed in this pull request? _unit_ and _integration_ checks run tests in mutually exclusive submodules. We may skip _integration_ check if only unit *tests* are changed. However, we need to run _integration_ if any helper is changed, since we don't know if it's used by integration tests or not. We can distinguish tests and test utilities by: * file name pattern (`Test\*.java` are tests, others are utilities) OR * extracting unit tests into separate submodule (similar to `ratis-test` in Ratis) The first approach is quick and dirty. The second one needs a bit more work, but is clean and has the additional benefit that all tests can be run despite any failures in dependencies. (Currently a test failure in e.g. `hdds-common` causes build/test in `hdds-server-framework` and other modules that depend on it.) The downside is that it may cause many merge conflicts for everyone (feature branches, other in-progress work, open PRs). I propose to do it now the first way, then do it properly after current feature branches are merged. https://issues.apache.org/jira/browse/HDDS-6186 ## How was this patch tested? Added test cases in `selective_ci_checks.bats`. ``` bats dev-support/ci/selective_ci_checks.bats ✓ checkstyle and bats ✓ compose only ✓ compose and robot ✓ runner image update ✓ check script ✓ integration and unit: java change ✓ integration and unit: script change ✓ unit only ✓ unit helper ✓ integration only ✓ kubernetes only ✓ docs only ✓ java-only change ✓ java and compose change ✓ java and docs change ✓ pom change ✓ CI lib change ✓ CI workflow change ✓ root README ✓ ignored code ✓ other README 21 tests, 0 failures ``` https://github.com/adoroszlai/hadoop-ozone/actions/runs/1812880105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
