smengcl commented on a change in pull request #3061:
URL: https://github.com/apache/ozone/pull/3061#discussion_r803163461



##########
File path: dev-support/ci/selective_ci_checks.bats
##########
@@ -99,6 +99,39 @@ load bats-assert/load.bash
   assert_output -p needs-kubernetes-tests=false
 }
 
+@test "integration and unit: script change" {
+  run dev-support/ci/selective_ci_checks.sh c6850484f

Review comment:
       Interesting. Thanks for the explanation.
   
   Sounds a bit like a "hack" to me, but acceptable.
   
   A cleaner approach would be to, in some way, simply pass the relative file 
path to the project root to the `get_changed_files()` function in 
`selective_ci_checks.sh`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to