siddhantsangwan commented on a change in pull request #3049:
URL: https://github.com/apache/ozone/pull/3049#discussion_r805678614
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerMetrics.java
##########
@@ -37,27 +36,16 @@
private final MetricsSystem ms;
- @Metric(about = "The total amount of used space in GigaBytes that needs to "
+
- "be balanced.")
- private MutableGaugeLong dataSizeToBalanceGB;
+ @Metric(about = "The amount of Gigabytes that Container Balancer moved" +
+ " in the last iteration.")
+ private MutableCounterLong dataSizeMovedGB;
- @Metric(about = "The amount of Giga Bytes that have been moved to achieve " +
- "balance.")
- private MutableGaugeLong dataSizeMovedGB;
+ @Metric(about = "Number of containers that Container Balancer moved" +
+ " in the last iteration.")
+ private MutableCounterLong movedContainersNum;
- @Metric(about = "Number of containers that Container Balancer has moved" +
- " until now.")
- private MutableGaugeLong movedContainersNum;
-
- @Metric(about = "The total number of datanodes that need to be balanced.")
- private MutableGaugeLong datanodesNumToBalance;
Review comment:
Okay. I was thinking of replacing `datanodesNumToBalance` with something
like `datanodesNumInvolved`, which is more correct. Also since none of them
work currently, should we add these in a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
