siddhantsangwan commented on a change in pull request #3049:
URL: https://github.com/apache/ozone/pull/3049#discussion_r811784075
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/balancer/TestContainerBalancer.java
##########
@@ -214,15 +215,12 @@ public void
unBalancedNodesListShouldBeEmptyWhenClusterIsBalanced() {
balancerConfiguration.setThreshold(99.99);
containerBalancer.start(balancerConfiguration);
- // waiting for balance completed.
- // TODO: this is a temporary implementation for now
- // modify this after balancer is fully completed
- try {
- Thread.sleep(100);
- } catch (InterruptedException e) { }
+ sleepWhileBalancing(100);
containerBalancer.stop();
+ ContainerBalancerMetrics metrics = containerBalancer.getMetrics();
Assert.assertEquals(0, containerBalancer.getUnBalancedNodes().size());
+ Assert.assertEquals(0, metrics.getDatanodesNumUnbalanced());
Review comment:
We're already testing this in `testMetrics()` at line 513:
```
Assert.assertEquals(determineExpectedUnBalancedNodes(
balancerConfiguration.getThreshold()).size(),
metrics.getDatanodesNumUnbalanced());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
