sodonnel commented on a change in pull request #3078:
URL: https://github.com/apache/ozone/pull/3078#discussion_r805998826
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/PipelineEndpoint.java
##########
@@ -105,9 +104,9 @@ public Response getPipelines() {
.setDatanodes(datanodes)
.setDuration(duration)
.setStatus(pipeline.getPipelineState())
- .setReplicationFactor(ReplicationConfig
-
.getLegacyFactor(pipeline.getReplicationConfig()).getNumber())
- .setReplicationType(pipeline.getType().toString());
+ .setReplicationFactor(
Review comment:
Would it make more sense to change the parameters here to accept just
"ReplicationConfig" rather than Factor and Type separately? Then internally it
can call the methods on ReplicationConfig it requires?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
