sodonnel commented on a change in pull request #3078:
URL: https://github.com/apache/ozone/pull/3078#discussion_r806001297
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/DatanodePipeline.java
##########
@@ -17,22 +17,22 @@
*/
package org.apache.hadoop.ozone.recon.api.types;
-import org.apache.hadoop.hdds.client.ReplicationConfig;
-
import java.util.UUID;
/**
* Metadata object that contains pipeline information of a Datanode.
*/
public class DatanodePipeline {
private UUID pipelineID;
- private ReplicationConfig repConfig;
+ private String replicationType;
+ private String replicationFactor;
private String leaderNode;
- public DatanodePipeline(UUID pipelineID, ReplicationConfig repConfig,
- String leaderNode) {
+ public DatanodePipeline(UUID pipelineID, String replicationType,
Review comment:
Similar comment here - I think it was better to have ReplicationConfig
as the parameter in the constructor and store that in the class, but then in
the accessors we can return the string representations by calling the correct
method on the stored ReplicationConfig?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
