JacksonYao287 commented on a change in pull request #2944:
URL: https://github.com/apache/ozone/pull/2944#discussion_r806651663
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -108,35 +118,24 @@
* new ContainerBalancerConfiguration and ContainerBalancerMetrics.
* Container Balancer does not start on construction.
*
- * @param nodeManager NodeManager
- * @param containerManager ContainerManager
- * @param replicationManager ReplicationManager
- * @param ozoneConfiguration OzoneConfiguration
+ * @param scm the storage container manager
*/
- public ContainerBalancer(
- NodeManager nodeManager,
- ContainerManager containerManager,
- ReplicationManager replicationManager,
- OzoneConfiguration ozoneConfiguration,
- final SCMContext scmContext,
- NetworkTopology networkTopology,
- PlacementPolicy placementPolicy) {
- this.nodeManager = nodeManager;
- this.containerManager = containerManager;
- this.replicationManager = replicationManager;
- this.ozoneConfiguration = ozoneConfiguration;
- this.config = ozoneConfiguration.
- getObject(ContainerBalancerConfiguration.class);
+ public ContainerBalancer(StorageContainerManager scm) {
+ this.nodeManager = scm.getScmNodeManager();
+ this.containerManager = scm.getContainerManager();
+ this.replicationManager = scm.getReplicationManager();
+ this.ozoneConfiguration = scm.getConfiguration();
+ this.config = new ContainerBalancerConfiguration();
Review comment:
thanks , will fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
