JacksonYao287 commented on a change in pull request #2944:
URL: https://github.com/apache/ozone/pull/2944#discussion_r806781046
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -184,7 +184,36 @@ private void balance() {
//run balancer infinitely
this.iterations = Integer.MAX_VALUE;
}
+
for (int i = 0; i < iterations && balancerRunning; i++) {
+ if (config.getTriggerDuEnable()) {
+ // before starting a new iteration, we trigger all the datanode
+ // to run `du`. this is an aggressive action, with which we can
+ // get more precise usage info of all datanodes before moving.
+ // this is helpful for container balancer to make more appropriate
+ // decisions. this will increase the disk io load of data nodes, so
+ // please enable it with caution.
+ sendRefreshUsageCommandToAllDNs();
+ synchronized (this) {
+ try {
+ long nodeReportInterval =
+ ozoneConfiguration.getTimeDuration(HDDS_NODE_REPORT_INTERVAL,
+ HDDS_NODE_REPORT_INTERVAL_DEFAULT, TimeUnit.MILLISECONDS);
+ // one for sending command , one for running du, and one for
+ // reporting back make it like this for now, a more suitable
+ // value. can be set in the future if needed
+ wait(3 * nodeReportInterval);
+ } catch (InterruptedException e) {
Review comment:
good point , will add this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
